From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [pull] require C99, add robustness and small fixes
Date: Fri, 15 Jun 2012 13:19:39 +0200 [thread overview]
Message-ID: <20120615111939.GB23464@x2.net.home> (raw)
In-Reply-To: <20120615104635.GA23464@x2.net.home>
On Fri, Jun 15, 2012 at 12:46:35PM +0200, Karel Zak wrote:
> On Mon, Jun 11, 2012 at 10:19:02PM +0200, Sami Kerola wrote:
> > blkdev: add blkdev_scsi_type_to_name()
> > lsblk: use blkdev_scsi_type_to_name()
I have modified this code. It seems better to return static strings
from blkdev_scsi_type_to_name() (Please, don't use xalloc.h stuff in
lib/ as we use the functions from lib/ in shared libraries.)
It seems better to have fallbacks for unknown SCSI types in
applications (for example lsblk uses "part" or "disk").
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-06-15 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 21:11 [pull] require C99, add robustness and small fixes Sami Kerola
2012-06-10 21:46 ` Bertrand Jacquin
2012-06-11 9:48 ` Karel Zak
2012-06-11 20:19 ` Sami Kerola
2012-06-15 10:46 ` Karel Zak
2012-06-15 11:19 ` Karel Zak [this message]
2012-06-11 22:29 ` Bertrand Jacquin
2012-06-12 8:36 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615111939.GB23464@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).