From: Karel Zak <kzak@redhat.com>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
util-linux@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Rob Landley <rob@landley.net>,
Bernhard Voelker <mail@bernhard-voelker.de>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] docs: block: update ioprio.txt
Date: Tue, 19 Jun 2012 12:19:28 +0200 [thread overview]
Message-ID: <20120619101928.GD13108@x2.net.home> (raw)
In-Reply-To: <1340095897-9014-1-git-send-email-wenqing.lz@taobao.com>
On Tue, Jun 19, 2012 at 04:51:37PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> The ionice.c in ioprio.txt document needed updating for the latest util-linux
> version.
>
> CC: Jens Axboe <axboe@kernel.dk>
> CC: Rob Landley <rob@landley.net>
> CC: Bernhard Voelker <mail@bernhard-voelker.de>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
> Documentation/block/ioprio.txt | 174 +++++++++++++++++++++++++---------------
> 1 files changed, 109 insertions(+), 65 deletions(-)
BTW, does it make sense to maintain duplicate, untested and unused
code in kernel docs if we already have regular ionice(1) implementation
in util-linux?
Would be better to add URL to *maintained* code?
http://git.kernel.org/?p=utils/util-linux/util-linux.git;a=blob_plain;f=schedutils/ionice.c;hb=HEAD
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-06-19 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 8:51 [PATCH] docs: block: update ioprio.txt Zheng Liu
2012-06-19 10:19 ` Karel Zak [this message]
[not found] ` <CAG27Bk2tXprRfMfYOVdWtwSbjw5Rw9Kxs6Wns+Gm65m3hoJawg@mail.gmail.com>
2012-06-19 10:27 ` Zheng Liu
2012-06-21 4:50 ` Rob Landley
2012-06-21 6:50 ` Sami Kerola
2012-06-21 10:19 ` gnehzuil.lzheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619101928.GD13108@x2.net.home \
--to=kzak@redhat.com \
--cc=axboe@kernel.dk \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@bernhard-voelker.de \
--cc=rob@landley.net \
--cc=util-linux@vger.kernel.org \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).