From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [pull] few utmpdump fixes
Date: Tue, 10 Jul 2012 11:35:54 +0200 [thread overview]
Message-ID: <20120710093554.GB5281@x2.net.home> (raw)
In-Reply-To: <CAG27Bk3f3moSFyOzLiTiRE-1vSVJn+PFh0-K_s65cD=h8MdJgg@mail.gmail.com>
On Sun, Jul 08, 2012 at 11:38:47PM +0200, Sami Kerola wrote:
> Sami Kerola (5):
> docs: clean up utmpdump.1 manual
> utmpdump: white space fix
> utmpdump: fixes based on static analysis [cppcheck]
Applied, but without field width limits for integers, IMHO it's unnecessary.
> utmpdump: use inotify to when following file
> utmpdump: encourage users not to follow stdin
I thought about inotify too :-) The --follow feature is almost useless
for utmp (where utmp records are reused), but for wtmp is inotify nice
and more smart solution than the original sleep() + read().
Applied with some changes, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-07-10 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 21:38 [pull] few utmpdump fixes Sami Kerola
2012-07-10 9:35 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710093554.GB5281@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).