From: Petr Uzel <petr.uzel@suse.cz>
To: util-linux <util-linux@vger.kernel.org>
Cc: Davidlohr Bueso <dave@gnu.org>
Subject: Re: [PATCH] fdisk: API: add label probing functionality
Date: Thu, 12 Jul 2012 11:45:02 +0200 [thread overview]
Message-ID: <20120712094502.GK1886@foxbat.suse.cz> (raw)
In-Reply-To: <1341783627.2628.10.camel@offbook>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Sun, Jul 08, 2012 at 11:40:27PM +0200, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> This patch sets the initial layout for label specific operations. A new fdisk_label structure
> is created that will hold all these ops, like new, delete, write and probe, among others. For
> now only probing is implemented. Once this design is established, a copy of the probed label
> will be copied to the main context structure, where calling the specific functions will save
> 'disklabel' checks. Debugging support is added as well.
>
> This patch passes regression tests and manually passes bsd, sun, dos and sgi labels probes.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Looks good to me:
Reviewed-by: Petr Uzel <petr.uzel@suse.cz>
I have two patches for you to consider taking them into your next
series (on top of this patch) - I'll send them separately.
Thanks,
Petr
--
Petr Uzel
IRC: ptr_uzl @ freenode
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-07-12 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 21:40 [PATCH] fdisk: API: add label probing functionality Davidlohr Bueso
2012-07-12 9:45 ` Petr Uzel [this message]
2012-07-16 16:03 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712094502.GK1886@foxbat.suse.cz \
--to=petr.uzel@suse.cz \
--cc=dave@gnu.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).