From: Karel Zak <kzak@redhat.com>
To: Milan Broz <mbroz@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] lsblk: add read-ahead column.
Date: Thu, 26 Jul 2012 11:45:42 +0200 [thread overview]
Message-ID: <20120726094542.GC17589@x2.net.home> (raw)
In-Reply-To: <1343140473-15035-1-git-send-email-mbroz@redhat.com>
On Tue, Jul 24, 2012 at 04:34:33PM +0200, Milan Broz wrote:
> misc-utils/lsblk.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied, thanks.
> @@ -1333,6 +1340,7 @@ int main(int argc, char *argv[])
> columns[ncolumns++] = COL_ROTA;
> columns[ncolumns++] = COL_SCHED;
> columns[ncolumns++] = COL_RQ_SIZE;
> + columns[ncolumns++] = COL_RA;
> break;
So -t output has been changed... I have added to the man page:
The default output as well as default output from options like
--topology and --fs is subject to change, so whenever possible you
should avoid using default outputs in your scripts. Always
explicitly define expected columns by '--output columns' in
environment where a stable output is required.
it seems that we need this in all our new utils (findmnt, lslocks,
partx, ...) where is --output option. I think it's good idea to force
users to write robust scripts :-)
Comments?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-07-26 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:34 [PATCH] lsblk: add read-ahead column Milan Broz
2012-07-26 9:45 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726094542.GC17589@x2.net.home \
--to=kzak@redhat.com \
--cc=mbroz@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).