From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: John Lane <util-linux@jelmail.com>, util-linux@vger.kernel.org
Subject: Re: fdisk geometry
Date: Thu, 26 Jul 2012 12:38:19 +0200 [thread overview]
Message-ID: <20120726103819.GJ12592@x2.net.home> (raw)
In-Reply-To: <1343298581.2609.8.camel@offbook>
On Thu, Jul 26, 2012 at 12:29:41PM +0200, Davidlohr Bueso wrote:
> On Thu, 2012-07-26 at 11:57 +0200, Karel Zak wrote:
> > On Thu, Jul 26, 2012 at 11:29:40AM +0200, Davidlohr Bueso wrote:
> > > > (a) where fdisk gets the information about the geometry from in this
> > > > specific case?
> > >
> > > fdisk gets the information from (i) user input, (ii) what the
> > > kernel/bios thinks the geometry is, with the HDIO_GETGEO ioctl and (iii)
> > > by inferring it from the partition table geometry.
> >
> > BTW, does it make any sense to read the geometry from partition table
> > if the partition table has been aligned according to the device topology
> > (for example 1MiB offset and grain)?
>
> Hmm not really, no. In any case we got rid of the pt geometry,
> __discover_system_geometry() only gets the info from the kernel.
I have moved get_partition_table_geometry() to dos_probe_label() :-)
It seems we need if (dos_compatible) there.
It means that for MBR we still read the PT geometry ;-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-07-26 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 1:34 fdisk geometry John Lane
2012-07-26 9:29 ` Davidlohr Bueso
2012-07-26 9:57 ` Karel Zak
2012-07-26 10:29 ` Davidlohr Bueso
2012-07-26 10:38 ` Karel Zak [this message]
2012-07-28 0:20 ` John Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726103819.GJ12592@x2.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=util-linux@jelmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).