From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: [PATCH] tests: use ts_is_mounted in mount/regfile
Date: Mon, 30 Jul 2012 17:20:56 +0200 [thread overview]
Message-ID: <20120730152056.GG5845@x2.net.home> (raw)
In-Reply-To: <50125C24.6090708@bernhard-voelker.de>
On Fri, Jul 27, 2012 at 11:15:16AM +0200, Bernhard Voelker wrote:
> > $ /home/berny/ul/umount /home/berny/ul/tests/output/mount/regfile.img
> > umount: /home/berny/ul/tests/output/mount/regfile.img: not mounted
>
> hmm, also other tests like mount/remount are failing.
>
> Somehow, I have the impression that TS_MOUNTPOINT should be canonicalized
Good point.
I have added ts_canonicalize() and improved ts_init() to use it for
all basic paths. It's probably more robust to use realpaths everywhere.
> in function.sh in ts_init_core_env and ts_init_core_subtest_env, but on the
> other side, this would eclipse errors like the above. WDYT?
Well, important is to detect if the filesystem is mounted. We have
special tests for mounting by symlinks where ts_canonicalize() is not
called for the mountpoint.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-07-30 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 9:06 [PATCH] tests: use ts_is_mounted in mount/regfile Bernhard Voelker
2012-07-27 9:15 ` Bernhard Voelker
2012-07-30 15:20 ` Karel Zak [this message]
2012-07-30 15:14 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730152056.GG5845@x2.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).