From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: tests: blkid/md-raid1-part fails
Date: Tue, 31 Jul 2012 15:51:24 +0200 [thread overview]
Message-ID: <20120731135124.GB17896@x2.net.home> (raw)
In-Reply-To: <501772B7.2040504@bernhard-voelker.de>
On Tue, Jul 31, 2012 at 07:52:55AM +0200, Bernhard Voelker wrote:
> The above mentioned test fails here (OpenSuSE-12.1 64-bit).
>
> That's in diff/blkid/md-raid1-part:
>
> --- /media/sdb5/berny/git/util-linux/tests/expected/blkid/md-raid1-part 2012-07-27 09:54:03.769967754 +0200
> +++ /media/sdb5/berny/git/util-linux/tests/output/blkid/md-raid1-part 2012-07-31 07:18:24.057815522 +0200
> @@ -44,7 +44,7 @@
>
>
> ID_FS_VERSION=0.90.0
> -ID_PART_ENTRY_DISK=8:16
> +ID_PART_ENTRY_DISK=8:112
> ID_PART_ENTRY_NUMBER=1
> ID_PART_ENTRY_OFFSET=2048
> ID_PART_ENTRY_SCHEME=dos
> @@ -56,7 +56,7 @@
>
>
> ID_FS_VERSION=0.90.0
> -ID_PART_ENTRY_DISK=8:16
> +ID_PART_ENTRY_DISK=8:112
> ID_PART_ENTRY_NUMBER=2
> ID_PART_ENTRY_OFFSET=53248
> ID_PART_ENTRY_SCHEME=dos
>
> What's wrong with that minor number?
Nothing, it would be better to check if the line ID_PART_ENTRY_DISK=
is in the $TS_OUTPUT and if yes then remove the line from the output
file (e.g. by sed).
The tests should not rely on device numbers and device names -- on
another places you can found /dev/loop0 in the expected outputs...
Patches wanted :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-07-31 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 5:52 tests: blkid/md-raid1-part fails Bernhard Voelker
2012-07-31 13:51 ` Karel Zak [this message]
2012-07-31 14:38 ` Bernhard Voelker
2012-07-31 18:03 ` Karel Zak
2012-08-01 6:21 ` Bernhard Voelker
2012-08-01 8:40 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731135124.GB17896@x2.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).