From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:49701 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388Ab2HAJRm (ORCPT ); Wed, 1 Aug 2012 05:17:42 -0400 Date: Wed, 1 Aug 2012 11:17:36 +0200 From: Karel Zak To: Bernhard Voelker Cc: "util-linux@vger.kernel.org" Subject: Re: [PATCH] tests: fix layout info in dos and non-dos mode fdisk test Message-ID: <20120801091736.GB1019@x2.net.home> References: <5018DCC8.1050803@bernhard-voelker.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5018DCC8.1050803@bernhard-voelker.de> Sender: util-linux-owner@vger.kernel.org List-ID: On Wed, Aug 01, 2012 at 09:37:44AM +0200, Bernhard Voelker wrote: > since you added the layout info to ts/fdisk/mbr-dos-mode, that test fails. > It seems you inserted too many blanks in the header line (... or that test > behaves differently on my machine). > Likewise with the new mbr-nondos-mode test. Hmm.. good catch. > Given the result is not hosed on my machine, I've attached a patch > to adapt the expected output of both tests. This is not proper fix. The whitespace is dynamically generated by fdisk according to device name size. It means that we have to standardize the blanks in the header line for the test. The problem should be fixed now. It would be nice standardize the headers and devnames in all tests where is fdisk output. Karel -- Karel Zak http://karelzak.blogspot.com