From: Karel Zak <kzak@redhat.com>
To: Niels de Vos <ndevos@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [RFC] mount: overwrite options from /etc/fstab when given on the commandline
Date: Wed, 1 Aug 2012 12:32:48 +0200 [thread overview]
Message-ID: <20120801103248.GA7670@x2.net.home> (raw)
In-Reply-To: <5019017E.4050704@redhat.com>
On Wed, Aug 01, 2012 at 12:14:22PM +0200, Niels de Vos wrote:
> On 08/01/2012 12:03 PM, Karel Zak wrote:
> > On Wed, Aug 01, 2012 at 11:48:33AM +0200, Karel Zak wrote:
> >>> Some options are not allowed to be
> >>> passed multiple times (like the SElinux context options) and mounting will fail
> >>> if options are present in both /etc/fstab and on the commandline.
> >>
> >> This is stupid SELinux disadvantage and SELinux should be fixed.
> >
> > Note that mount(8) and libmount removes all selinux context options on
> > remount for kernels< 2.6.39 because SELinux context remount was
> > unsupported, so this SELinux disadvantage should be hidden for usual
> > use case.
> >
> > Maybe we can also add another exception for SELinux to de-duplicate
> > the SELinux context options in the options string. It's not perfect,
> > but probably acceptable for SELinux -- I can do this for 2.22-rc2.
>
> That would be great. What is your opinion on getting the SElinux options
> handled differently in the kernel instead or in addition?
SELinux is no filesystem and we already have (must have) SELinux
specific code in mount(8) (and many others utils;-).
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-08-01 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 9:11 [RFC] mount: overwrite options from /etc/fstab when given on the commandline Niels de Vos
2012-08-01 9:48 ` Karel Zak
2012-08-01 10:03 ` Karel Zak
2012-08-01 10:14 ` Niels de Vos
2012-08-01 10:32 ` Karel Zak [this message]
2012-08-01 11:58 ` Niels de Vos
2012-08-01 17:08 ` Karel Zak
2012-08-02 9:46 ` Niels de Vos
2012-08-01 10:11 ` Niels de Vos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801103248.GA7670@x2.net.home \
--to=kzak@redhat.com \
--cc=ndevos@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).