util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: faizan husain <faizanh@linux.vnet.ibm.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] lscpu : -b and -c option does not give expected output.
Date: Tue, 7 Aug 2012 09:35:09 +0200	[thread overview]
Message-ID: <20120807073509.GA31284@osiris.de.ibm.com> (raw)
In-Reply-To: <5020A7F8.9070402@linux.vnet.ibm.com>

On Tue, Aug 07, 2012 at 11:00:32AM +0530, faizan husain wrote:
> On Monday 06 August 2012 05:20 PM, Heiko Carstens wrote:
> >On Sun, Aug 05, 2012 at 10:10:52PM -0700, Faizan husain wrote:
> >>From: faizan husain <faizanh@linux.vnet.ibm.com>
> >>
> >>Options for lscpu command are giving incorrect output.
> >>As per the man page or help, '-b' option should limit the output to online CPUs
> >>and '-c' option should limit the output to offline CPUs.
> >>But we could see the output is same for '-a','-b' and '-c' options.
> >>
> >>Signed-off-by: faizan husain <faizanh@linux.vnet.ibm.com>
> >The -a, -b and -c options were meant to influence the output for the
> >extended (-e) and parsable (-p) output options.
> >I'm not sure it makes sense to change the default output with these
> >options. I'd prefer an update of the man page.
> >
> >Hm?
> This fix is not going to influence the default output with these
> options (-e and -p),

Yes, I'm aware of that.

> and it does not make any sense if -a, -b and -c option print same output.

Just to make sure we talk about the same things:

extended output: -e option
parsable output: -p option
default output : no -e or -p option specified

What I tried to say above was that the -a, -b and -c modifiers were
only added to influence the output for the extended and parsable
options.
If you have a system with a lot of cpus the output can be significantly
different for the extended and parsable options if you specify any of the
modifiers.

The default output (no -e or -p) however is intended to give an overview
of the complete system.

So from a usability point of view: why would a user want to exclude the
line which contains the online list of cpus for the default output?

>From my point of view the correct "fix" would be to change the lscpu man
page in order to document that the -a, -b and -c modifiers only influence
the output for the extended and parsable options.


  reply	other threads:[~2012-08-07  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06  5:10 [PATCH] lscpu : -b and -c option does not give expected output Faizan husain
2012-08-06 11:50 ` Heiko Carstens
2012-08-07  5:30   ` faizan husain
2012-08-07  7:35     ` Heiko Carstens [this message]
2012-08-07  8:23       ` Bernhard Voelker
2012-08-07  9:01       ` faizan husain
  -- strict thread matches above, loose matches on Subject: below --
2012-08-05 10:37 Faizan husain
2012-08-06  5:08 ` faizan husain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807073509.GA31284@osiris.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=faizanh@linux.vnet.ibm.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).