From: Karel Zak <kzak@redhat.com>
To: Moritz Barsnick <barsnick@gmx.net>
Cc: util-linux list <util-linux@vger.kernel.org>
Subject: Re: util-linux-2.22: backward compatibility of wdctl
Date: Fri, 7 Sep 2012 18:20:44 +0200 [thread overview]
Message-ID: <20120907162044.GE23242@x2.net.home> (raw)
In-Reply-To: <20120905112717.GA14130@sunshine.barsnick.net>
On Wed, Sep 05, 2012 at 01:27:17PM +0200, Moritz Barsnick wrote:
> congratulations on util-linux 2.22. BTW, I recently took the liberty of
> refreshing the freshmeat aka freecode entry, and submitted an update
> for 2.22 today. I hope that's okay.
..arbitrary advertising is okay.
> Anyway, just for the fun of it, I was trying to compile util-linux on
> an SLES10 (SUSE Linux Enterprise) machine. That's one of those
Do you know that we had -rc1 and -rc2 release? :-)
> enterprise distributions with somewhat ancient environments. ;-) But
> nothing out of the ordinary nowadays, I think.
Well, it seems that you have kernel header < 2.6.18 (the macros has
been added in Apr and May 2006).
> CC sys-utils/wdctl.o
> sys-utils/wdctl.c:53:4: error: 'WDIOF_PRETIMEOUT' undeclared here (not in a function)
> sys-utils/wdctl.c: In function 'read_watchdog':
> sys-utils/wdctl.c:352:17: error: 'WDIOC_GETPRETIMEOUT' undeclared (first use in this function)
> sys-utils/wdctl.c:352:17: note: each undeclared identifier is reported only once for each function it appears in
> sys-utils/wdctl.c:352:3: warning: passing argument 2 of 'ioctl' makes integer from pointer without a cast [enabled by default]
> In file included from sys-utils/wdctl.c:21:0:
> /usr/include/sys/ioctl.h:42:12: note: expected 'long unsigned int' but argument is of type 'const struct wdflag *'
> sys-utils/wdctl.c:354:17: error: 'WDIOC_GETTIMELEFT' undeclared (first use in this function)
> sys-utils/wdctl.c:354:3: warning: passing argument 2 of 'ioctl' makes integer from pointer without a cast [enabled by default]
> In file included from sys-utils/wdctl.c:21:0:
> /usr/include/sys/ioctl.h:42:12: note: expected 'long unsigned int' but argument is of type 'const struct wdflag *'
> make[2]: *** [sys-utils/wdctl.o] Error 1
Fixed.
> This system's/kernel's watchdog.h doesn't have those #defines:
Sure, it's always bad/expensive idea to mix old OS and new system
packages.
> To add to the misery, it isn't possible to disable the build of wdctl
> AFAICT.
Fixed, I have added --disable-wdctl.
> 2.6.16.60-0.58.1.3835.0.PTF.638363-smp
yep...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-09-07 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:27 util-linux-2.22: backward compatibility of wdctl Moritz Barsnick
2012-09-05 13:37 ` Bernhard Voelker
2012-09-05 15:22 ` Moritz Barsnick
2012-09-07 16:20 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907162044.GE23242@x2.net.home \
--to=kzak@redhat.com \
--cc=barsnick@gmx.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).