util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Andrea Bonomi <a.bonomi@endian.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/2] agetty: display network address in issue
Date: Thu, 13 Sep 2012 13:05:39 +0200	[thread overview]
Message-ID: <20120913110539.GA13016@x2.net.home> (raw)
In-Reply-To: <49CAD42E-995E-4C66-A9AD-5939968A54F7@endian.com>

On Wed, Sep 12, 2012 at 07:29:19PM +0200, Andrea Bonomi wrote:
> Hi,
> good idea, much better without the hardcoded interface name.
> I think that the --interface option is useful for the machine with a dynamic IP address.
> (in my experience, the getaddrinfo based on the hostname returns the loopback address)
> 
> Another idea will be to add the interface name after the \4 or \6, something like:
> \4eth0 (or similar…)

Excellent idea. It also means that --interface is unnecessary and
more than one interface IP maybe be printed by the issue file.

> to get the IPv4 address of the interface eth0
> So the user can specify the interface name directly in the issue file.
> What do you think?

Implemented, merged into master branch. For example:

    lo = \4{lo}
   em1 = \4{em1}  (IPv6 \6{em1})
virbr0 = \4{virbr0}

The {..} is optional argument, if not given, host IP is printed.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply	other threads:[~2012-09-13 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2B6CF89C-6218-4289-B116-27108562664F@endian.com>
2012-08-15  9:08 ` [PATCH 0/2] agetty: display network address in issue Andrea Bonomi
2012-09-12  9:37   ` Karel Zak
2012-09-12 17:29     ` Andrea Bonomi
2012-09-13 11:05       ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913110539.GA13016@x2.net.home \
    --to=kzak@redhat.com \
    --cc=a.bonomi@endian.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).