From: Karel Zak <kzak@redhat.com>
To: Giacomo <giacomo.perale@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: rtcwake doesn't reset wakealarm
Date: Thu, 13 Sep 2012 13:25:46 +0200 [thread overview]
Message-ID: <20120913112546.GB13016@x2.net.home> (raw)
In-Reply-To: <loom.20120912T191123-580@post.gmane.org>
On Wed, Sep 12, 2012 at 05:33:39PM +0000, Giacomo wrote:
> That was needlessly complex. The issue never was "don't call RTC_AIE_OFF if you
> didn't call RTC_AIE_ON before," it was "don't call RTC_AIE_OFF if it is not
> supported."
Good point.
>
> So to disable an alarm use the same logic used to enable it: first try
> RTC_WKALM_SET with the "enabled" flag set to false, if it fails fall back to
> RTC_AIE_OFF.
>
> This patch works for me as well and it seems to me it's cleaner than my previous
> one.
Applied, thanks. (You forgot 'Signed-off-by:' but I guess you agree
with this line in the commit message... )
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-09-13 11:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 11:11 rtcwake doesn't reset wakealarm Giacomo
2012-09-12 9:52 ` Giacomo
2012-09-12 10:09 ` Karel Zak
2012-09-12 10:31 ` Karel Zak
2012-09-12 14:33 ` Giacomo
2012-09-12 17:33 ` Giacomo
2012-09-13 11:25 ` Karel Zak [this message]
2012-09-13 16:31 ` Paul Fox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913112546.GB13016@x2.net.home \
--to=kzak@redhat.com \
--cc=giacomo.perale@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox