From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: Petr Uzel <petr.uzel@suse.cz>, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 1/3] fdisk: add guid
Date: Fri, 21 Sep 2012 16:38:16 +0200 [thread overview]
Message-ID: <20120921143816.GB18699@x2.net.home> (raw)
In-Reply-To: <20120921130543.GA643@gnu.org>
On Fri, Sep 21, 2012 at 09:05:43AM -0400, Davidlohr Bueso wrote:
> I honestly don't see much difference between doing it before or
> after GPT, since all the other labels need to be adapted anyway.
I see a difference. Why we need struct fdisk_guid in struct where we
define DOS partition types? Why there is {0} everywhere?
Do you want to remove all these changes later?
Anyway, I have no problem to write the patch to split part types to
separate per-label tables :-)
It also seems that you're introduce a new hex codes for GPT partition
types. It means that you want to use int16_t to address types defined
by UUIDs. Is it good idea? Would be better to address the types by
numbers <1-N> as printed in the menu or directly by UUIDs?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-09-21 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 12:03 [PATCH 1/3] fdisk: add guid Davidlohr Bueso
2012-09-21 11:12 ` Karel Zak
2012-09-21 11:25 ` Petr Uzel
2012-09-21 13:05 ` Davidlohr Bueso
2012-09-21 14:38 ` Karel Zak [this message]
2012-09-21 15:04 ` Davidlohr Bueso
2012-09-24 8:20 ` Karel Zak
2012-09-24 8:43 ` Karel Zak
2012-09-24 11:14 ` Davidlohr Bueso
2012-09-24 11:24 ` Davidlohr Bueso
2012-09-24 11:16 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921143816.GB18699@x2.net.home \
--to=kzak@redhat.com \
--cc=dave@gnu.org \
--cc=petr.uzel@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).