From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Ayan George <ayan@ayan.net>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Use C99 idioms in kill.c
Date: Thu, 18 Oct 2012 22:18:07 +0400 [thread overview]
Message-ID: <20121018181807.GA25656@altlinux.org> (raw)
In-Reply-To: <508025be.e81S03iobeo1edmy%ayan@ayan.net>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
Hi,
On Thu, Oct 18, 2012 at 03:52:30PM +0000, Ayan George wrote:
> * Moved some declarations closer to where the vairable is used.
> * Declared variables used only in loops within the loop itself.
> ---
> misc-utils/kill.c | 45 +++++++++++++++++++--------------------------
> 1 file changed, 19 insertions(+), 26 deletions(-)
>
> diff --git a/misc-utils/kill.c b/misc-utils/kill.c
> index 6abfd24..2b88852 100644
> --- a/misc-utils/kill.c
> +++ b/misc-utils/kill.c
[...]
> - numsig = SIGTERM;
> - do_pid = (! strcmp (progname, "pid")); /* Yecch */
> - do_kill = 0;
> - check_all = 0;
> + int numsig = SIGTERM,
> + do_pid = (! strcmp (progname, "pid")), /* Yecch */
> + do_kill = 0;
> + check_all = 0;
Please enable your .git/hooks/pre-commit to stop these whitespace errors,
no matter whether to use C99 or not.
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-18 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 15:52 [PATCH] Use C99 idioms in kill.c Ayan George
2012-10-18 17:32 ` Karel Zak
2012-10-18 18:12 ` Ayan George
2012-10-18 18:18 ` Dmitry V. Levin [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-18 16:00 Ayan George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018181807.GA25656@altlinux.org \
--to=ldv@altlinux.org \
--cc=ayan@ayan.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).