util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <dave@gnu.org>
Cc: Petr Uzel <petr.uzel@suse.cz>, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] gpt: create empty disklabels
Date: Fri, 2 Nov 2012 12:35:03 +0100	[thread overview]
Message-ID: <20121102113503.GB30319@x2.net.home> (raw)
In-Reply-To: <1351358627.2842.3.camel@offbook>

On Sat, Oct 27, 2012 at 07:23:47PM +0200, Davidlohr Bueso wrote:
> This patch enables creating a new, empty, GPT disklabel from either
> an empty disk or one that already has a disklabel. For this
> purpose, a 'g' option is added to the main menu and is visible to all
> labels. Here's an example for a scsi_debug device (/dev/sdb):
> 
> ...
> Device does not contain a recognized partition table
> Building a new DOS disklabel with disk identifier 0x20a614c8.
> 3696: fdisk:  CONTEXT: zeroize in-memory first sector buffer
> 
> Command (m for help): g

 It would be be really nice to print a message, something like

    GPT disk label created.

 and it would be also nice to print label type in the 'p'(print)
 command output and maybe also PT uuid.

>  fdisks/fdisk.c |    4 ++
>  fdisks/gpt.c   |  202 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 200 insertions(+), 6 deletions(-)

 Applied, excellent, thanks!

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      parent reply	other threads:[~2012-11-02 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 17:23 [PATCH v2 2/2] gpt: create empty disklabels Davidlohr Bueso
2012-11-01  9:06 ` Petr Uzel
2012-11-02 11:35 ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102113503.GB30319@x2.net.home \
    --to=kzak@redhat.com \
    --cc=dave@gnu.org \
    --cc=petr.uzel@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).