From: Karel Zak <kzak@redhat.com>
To: Venkatraman S <venkat@linaro.org>
Cc: util-linux@vger.kernel.org, arnd.bergmann@linaro.org
Subject: Re: [RFC PATCH 0/4] Adding useful information into swap partition header
Date: Thu, 8 Nov 2012 10:44:42 +0100 [thread overview]
Message-ID: <20121108094442.GA2327@x2.net.home> (raw)
In-Reply-To: <CAFSEfh0A6JoKdhDyawc1=imRDZT7YFTUyDrVPaK-02CW1pGcRA@mail.gmail.com>
On Tue, Oct 23, 2012 at 07:07:42PM +0530, Venkatraman S wrote:
> On 23 October 2012 17:46, Karel Zak <kzak@redhat.com> wrote:
> > On Mon, Oct 22, 2012 at 10:27:23PM +0530, Venkatraman S wrote:
> >> Venkatraman S (4):
> >> libblkid/topology: add preferred_erase_size to topology probe
> >> mkswap: refactor header preparation
> >> mkswap: Add additional fields in swapheader
> >> mkswap: Probe and embed useful block device info into swapheader
> >
> > I don't see a problem to support additional information in the swap
> > header, but our rule is pretty simple: first in Linus' tree, after
> > that in userspace.
> >
>
> Thanks Karl - that's understood. I posted the patches to better explain the
> issue I faced - this new parameter I introduced in topology.c is accessible
> only when I pass the root disk dev node to mkswap (as /dev/mmcblkX)
> and not when invoked with /dev/mmcblkXpY) (i.e a partition with the device).
Well, the problem is that sysfs_{open,stat}() functions in
lib/sysfs.c reads attributes from parent only for "queue/" directory
attributes. It's trivial to fix this problem.
> So how should the topology probe be invoked in this case ?
The question is if we really need to extend libblkid if the attribute
is necessary only for mkswap.
I think it would be better to read the sysfs attribute directly in
mkswap (by lib/sysfs.c functions). The result will be one small patch
for mkswap.
Anyway, all this is trivial and maybe implemented very quickly --
what we need is to have support in kernel.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2012-11-08 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:57 [RFC PATCH 0/4] Adding useful information into swap partition header Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 1/4] libblkid/topology: add preferred_erase_size to topology probe Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 2/4] mkswap: refactor header preparation Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 3/4] mkswap: Add additional fields in swapheader Venkatraman S
2012-10-22 16:57 ` [PATCH 4/4] mkswap: Probe and embed useful block device info into swapheader Venkatraman S
2012-10-22 17:04 ` [RFC PATCH 0/4] Adding useful information into swap partition header Venkatraman S
2012-10-23 12:16 ` Karel Zak
2012-10-23 13:37 ` Venkatraman S
2012-11-08 9:44 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108094442.GA2327@x2.net.home \
--to=kzak@redhat.com \
--cc=arnd.bergmann@linaro.org \
--cc=util-linux@vger.kernel.org \
--cc=venkat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).