Re: [PATCH 3/3] fdisk: dos: always write mbr

[Karel Zak <kzak@redhat.com>]

On Wed, Nov 14, 2012 at 12:04:52AM -0800, Davidlohr Bueso wrote:
> There's no harm when writing the MBR, changed or not. This also

it's harm -- kernel has to parse the new PT, udev has to scan all the
stuff etc. ... many event and every event is painful if you have
complicated setup (DM, multipath, udisks, ...).

> allows us to get rid of the 'MBRbuffer_changed' global variable.

It would be nice to add to fdisk_context

    void *labeldata;

 and define in fdiskdos.h

 struct fdisk_dosdata {
    int write_status;             /* FDISKDOS_WRITE_* flags */
    ...
 }

 enum {
    FDISKDOS_WRITE_HDR     = (1 << 1)  /* header buffer modified (e.g. ID change) */
    FDISKDOS_WRITE_PT      = (1 << 2)  /* partition table modified */
    FDISKDOS_WRITE_EPT     = (1 << 3)  /* any extended partition table modified */
 };

(maybe you found better names for the macros and variables :-)


 than we can add fdisk_is_modified() and is_modified() to fdisk_label
 driver and remove all label specific junk from fdisk.c.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com