public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: util-linux@vger.kernel.org
Subject: Re: vlock command
Date: Fri, 16 Nov 2012 09:36:34 +0100	[thread overview]
Message-ID: <20121116083634.GA29284@x2.net.home> (raw)
In-Reply-To: <20121114235426.GE20303@altlinux.org>

On Thu, Nov 15, 2012 at 03:54:27AM +0400, Dmitry V. Levin wrote:

> Well, could you then explain why do you keep that
> 7 year old vlock-1.3-morepam.patch from Nalin in Fedora vlock package?

...to make it compatible with many others PAM applications. It's
common practice to use pam_authenticate() + pam_acct_mgmt() +
pam_setcred().  I don't think it's good idea to make any exceptions
from this practice.

You need pam_acct_mgmt() to check account validity, expiration etc.

> It does something unnatural for vlock, e.g. pam_acct_mgmt and even
> pam_setcred!  At the same time, the only module in its account stack is
> pam_permit.so.  Weird.

Well, it's only config file, $EDITOR /etc/pam.d/vlock is enough to
make your configuration more paranoid. It's definitely better to
support all the features by binary and define policies in config
files.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2012-11-16  8:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 10:35 vlock command Karel Zak
2012-11-14 11:04 ` Alexey Gladkov
2012-11-14 12:22   ` Karel Zak
2012-11-14 23:54     ` Dmitry V. Levin
2012-11-16  8:36       ` Karel Zak [this message]
2012-11-14 12:26   ` Karel Zak
2012-11-14 12:38     ` Alexey Gladkov
2012-11-14 23:31     ` Dmitry V. Levin
2012-11-15  6:44       ` Alexey Gladkov
2012-11-15  7:52         ` Karel Zak
2012-11-15  8:48           ` Petr Pisar
2012-11-15  9:35             ` Alexey Gladkov
2012-11-15  9:48               ` Karel Zak
2012-11-15 10:03                 ` Alexey Gladkov
2012-11-15 10:23               ` Petr Pisar
2012-11-16 10:01                 ` Alexey Gladkov
2012-11-16 13:21                   ` Petr Pisar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121116083634.GA29284@x2.net.home \
    --to=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox