From: Karel Zak <kzak@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] wipefs: Add --force option
Date: Tue, 20 Nov 2012 12:16:34 +0100 [thread overview]
Message-ID: <20121120111634.GH20338@x2.net.home> (raw)
In-Reply-To: <20121119154116.GA28909@rhmail.home.annexia.org>
On Mon, Nov 19, 2012 at 03:41:16PM +0000, Richard W.M. Jones wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=872831
> https://bugzilla.redhat.com/show_bug.cgi?id=865961
>
> Unfortunately this means you nearly always need to use the --force
> option with wipefs when trying to wipe something which is not an
> unmounted filesystem.
>
> Tested using a modified version of libguestfs which detects if wipefs
> supports the --force option, and if it does unconditionally adds it.
> I verified that this fixes the virt-format utility on Fedora 18.
Applied, thanks.
> This change adds the --force option which, when used, undoes the above
> flag change. However you still have to use --force most of the time
> when erasing something that isn't a plain unmounted filesystem.
I'll improve the code. It's stupid disadvantage that --force is
necessary for things like partitions tables. We have to use
O_EXCL more carefully.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-11-20 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 15:41 [PATCH] wipefs: Add --force option Richard W.M. Jones
2012-11-20 11:16 ` Karel Zak [this message]
2012-11-20 13:52 ` Karel Zak
2012-11-20 14:41 ` Richard W.M. Jones
2012-11-20 15:07 ` Milan Broz
2012-11-20 15:41 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120111634.GH20338@x2.net.home \
--to=kzak@redhat.com \
--cc=rjones@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).