From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-kernel-owner@vger.kernel.org Date: Mon, 26 Nov 2012 14:27:00 +0100 From: Karel Zak To: NeilBrown Cc: Jaegeuk Kim , util-linux@vger.kernel.org, Vyacheslav Dubeyko , Martin Steigerwald , linux-kernel@vger.kernel.org, Jaegeuk Kim , linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, arnd@arndb.de, tytso@mit.edu, chur.lee@samsung.com, cm224.lee@samsung.com, jooyoung.hwang@samsung.com Subject: Re: util-linux bug: was Re: [PATCH 00/16 v3] f2fs: introduce flash-friendly file system Message-ID: <20121126132700.GA28200@x2.net.home> References: <003d01cdb74b$0c3fa420$24beec60$%kim@samsung.com> <201211021439.02797.Martin@lichtvoll.de> <201211101933.38434.Martin@lichtvoll.de> <8A3372F6-6294-404E-909B-3FDE0C2368B7@dubeyko.com> <1352634168.1893.9.camel@kjgkr> <20121123112309.52429ceb@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20121123112309.52429ceb@notabene.brown> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Nov 23, 2012 at 11:23:09AM +1100, NeilBrown wrote: > This is a bug in util-linux. > > If 'blkid' doesn't recognise the filesystem, mount reads /etc/filesystems > and tries everything listed there. If that file ends with a '*', it should > read /proc/filesystems and try everything else listed that (that doesn't > start with 'nodev'). > > However it currently ignores the '*' and just adds everything Fixed. Thanks for the report! > The following patch (against git://github.com/karelzak/util-linux.git) fixes > it for me, though I suspect it should possible ignore 'ENODEV' too - > otherwise if /etc/filesystems contains an invalid filesystem name, it will > silently ignore all others. Good idea, implemented. ... all will be fixed in stable v2.22.2 release. Karel -- Karel Zak http://karelzak.blogspot.com