Re: [PATCH] agetty: map NL to CR-NL on output in initial termiossettings

["Dr. Werner Fink" <werner@suse.de>]

On Thu, Nov 24, 2011 at 06:55:57PM +0100, Dennis Jensen wrote:
> On Wed, 2011-11-23 at 12:08 +0100, Karel Zak wrote:
> > [CC: to Werner Fink]
> > 
> > On Wed, Nov 16, 2011 at 10:54:50AM +0100, Dennis Jensen wrote:
> > > This fixes situations where messages "scroll horizontally", making
> > 
> > Do you mean /etc/issue and prompt strings? The terminal end-of-line
> > should be detected in get_logname() and then the proper flags should
> > be set in termio_final().
> 
> I mean something like this, after enabling DEBUG: 
> 
> -wL8ttyS019200linuxaterm_io 2
>                              before autobaud
>                                             waiting for cr-lf

[...]

> 
> diff --git a/term-utils/agetty.c b/term-utils/agetty.c
> index 041e1f7..079a737 100644
> --- a/term-utils/agetty.c
> +++ b/term-utils/agetty.c
> @@ -1091,7 +1091,8 @@ static void termio_init(struct options *op, struct termios *tp)
>  #else
>  	tp->c_iflag = 0;
>  #endif
> -	tp->c_lflag = tp->c_oflag = 0;
> +	tp->c_lflag = 0;
> +	tp->c_oflag &= OPOST | ONLCR;
>  
>  	if ((op->flags & F_KEEPCFLAGS) == 0)
>  		tp->c_cflag = CS8 | HUPCL | CREAD | (tp->c_cflag & CLOCAL);


Indeed this should work even on some strange serial consoles.
Maybe this is also required for my patch set for sulogin as
with this set sulogin supports not only virtual consoles but
also serial consoles as well.


     Werner

-- 
  "Having a smoking section in a restaurant is like having
          a peeing section in a swimming pool." -- Edward Burr