From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <dreisner@archlinux.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Require explicit call to emergency_do_mounts
Date: Sun, 23 Dec 2012 23:03:35 +0100 [thread overview]
Message-ID: <20121223220335.GC25576@x2.redhat.com> (raw)
In-Reply-To: <1356277410-29666-1-git-send-email-dreisner@archlinux.org>
On Sun, Dec 23, 2012 at 10:43:30AM -0500, Dave Reisner wrote:
> Keeping these functions in lib/ with constructor and destructor
> attributes causes the code to be run in invocation of a large number of
> programs in the util-linux tree. Remove the attributes and call it
> explicitly from sulogin, the only place where it (currently) makes sense
> to be called from.
Ah, I've been faster then my fetchmail -- so I have pushed a
little different patch.
> I'd further vote that the flag which enables this behavior be turned off
> by default.
Good point, I think for mainstream distros it's unnecessary.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2012-12-23 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 15:43 [PATCH] Require explicit call to emergency_do_mounts Dave Reisner
2012-12-23 22:03 ` Karel Zak [this message]
2012-12-24 0:15 ` Bernhard Voelker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121223220335.GC25576@x2.redhat.com \
--to=kzak@redhat.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox