From: Karel Zak <kzak@redhat.com>
To: "Cristian Rodríguez" <crrodriguez@opensuse.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] include/bitops.h: Use the operating system byteswapping functions
Date: Tue, 8 Jan 2013 14:17:29 +0100 [thread overview]
Message-ID: <20130108131729.GE18204@x2.net.home> (raw)
In-Reply-To: <1356543501-7033-1-git-send-email-crrodriguez@opensuse.org>
On Wed, Dec 26, 2012 at 02:38:21PM -0300, Cristian Rodríguez wrote:
> There is no need to reinvent the wheel.
Well, htoXX function were added to glibc in version 2.9 (2009?), our
bitops.h is probably older.
Anyway, you're right that use libc implementation is good idea. I
have merged both patches and applied with some changes.
Please, use Signed-off-by: next time.
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-01-08 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 17:38 [PATCH] include/bitops.h: Use the operating system byteswapping functions Cristian Rodríguez
2012-12-26 18:48 ` Mike Frysinger
2012-12-26 19:01 ` Cristian Rodríguez
2013-01-08 13:17 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108131729.GE18204@x2.net.home \
--to=kzak@redhat.com \
--cc=crrodriguez@opensuse.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox