From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 2/4] ipcmk: remove unnecessary create_key() function
Date: Thu, 24 Jan 2013 16:32:21 +0100 [thread overview]
Message-ID: <20130124153221.GB27413@x2.net.home> (raw)
In-Reply-To: <20130110101955.GA593@x2.net.home>
On Thu, Jan 10, 2013 at 11:19:55AM +0100, Karel Zak wrote:
> On Wed, Jan 09, 2013 at 07:36:54PM +0000, Sami Kerola wrote:
> > static int create_shm(size_t size, int permission)
> > {
> > - key_t key = create_key();
> > + key_t key = random();
>
> we already have random_get_bytes() in randutils.c, it seems better
> than introduce seed_random() and use random().
>
> random_get_bytes(&key, sizeof(key));
Implemented.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-01-24 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 19:36 [PATCH 1/4] lib: add function to seed random() Sami Kerola
2013-01-09 19:36 ` [PATCH 2/4] ipcmk: remove unnecessary create_key() function Sami Kerola
2013-01-10 10:19 ` Karel Zak
2013-01-24 15:32 ` Karel Zak [this message]
2013-01-09 19:36 ` [PATCH 3/4] ipcmk: allow user to create more ipc resources at a time Sami Kerola
2013-01-10 9:25 ` Karel Zak
2013-01-09 19:36 ` [PATCH 4/4] include: add missing values to sysfs_cxt initializer definition Sami Kerola
2013-01-24 15:35 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124153221.GB27413@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox