From: Karel Zak <kzak@redhat.com>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: kerolasa@gmail.com, Util-Linux <util-linux@vger.kernel.org>
Subject: Re: [patches] a bunch of textual fixes, plus -V for renice
Date: Fri, 25 Jan 2013 12:10:17 +0100 [thread overview]
Message-ID: <20130125111017.GI27413@x2.net.home> (raw)
In-Reply-To: <1358688927.20076.140661179956885.59525AA5@webmail.messagingengine.com>
On Sun, Jan 20, 2013 at 02:35:27PM +0100, Benno Schulenberg wrote:
>
> Hello Sami,
>
> On Sun, Jan 20, 2013, at 12:25, Sami Kerola wrote:
> > + fprintf(stderr, _("%s from %s\n"),
> > + program_invocation_short_name, PACKAGE_STRING);
> >
> > should use UL version printing macro.
> >
> > + fprintf(stderr, UTIL_LINUX_VERSION);
>
> Ah. Okay. Then it is good to leave that out for now. I will provide a
> new patch for that later.
I have fixed this issue.
> > In the patch 0007 the renice(1) adds -V short option along side with
> > -v to print version. IMHO if the upper case option is added the lower
> > case equivalent should be dropped.
>
> I agree -v should be dropped for --version, but I didn't want to do that
> right away. Maybe one or two releases down the line?
Well, we have to care about backward compatibility. It seems better
to support (now undocumented) -v as well as new and documented -V.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-01-25 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 10:56 [patches] a bunch of textual fixes, plus -V for renice Benno Schulenberg
2013-01-20 11:25 ` Sami Kerola
2013-01-20 13:35 ` Benno Schulenberg
2013-01-25 11:10 ` Karel Zak [this message]
2013-01-25 11:07 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125111017.GI27413@x2.net.home \
--to=kzak@redhat.com \
--cc=bensberg@justemail.net \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox