Re: fsck files w/relative paths

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1228 bytes --]

On Friday 25 January 2013 10:17:36 Karel Zak wrote:
> On Sun, Jan 20, 2013 at 06:27:22PM -0500, Mike Frysinger wrote:
> > we could tweak parse_argv() so that it checks for argv[0] == '.' in
> > addition to argv[0] == '/'.  but that wouldn't fix other relative paths
> > like: $ fsck images/foo
> > $ fsck foo
> 
> Hmm... maybe add a hint to the fsck man page is the best solution :-)
> 
> > should we treat all non-options as devices ?  would that break anything ?
> 
> I don't think it's a good idea.
> 
> All unknown stuff is by default interpreted as filesystem specific options
> (options for fsck.<type>) and it's pretty common that people don't use
> "--" separator between fsck and fsck.<type> options.

well, i didn't mean non-fsck options, but non-options.  i.e. things that don't 
start with dashes.  are there fscks which use non-options as something other 
than "file/device to check" ?

really, the fsck checking here is simply to determine whether it has to 
automatically look up the root device and append that to the command line.  if 
the user specified a file/device, then that shouldn't happen.  we could even 
resort to doing a stat() on the non-options to see if it exists.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]