From: Karel Zak <kzak@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: libguestfs@redhat.com, berrange@redhat.com, util-linux@vger.kernel.org
Subject: Re: [Libguestfs] Should we always do wipefs before mkfs? Discuss ...
Date: Tue, 5 Feb 2013 10:20:03 +0100 [thread overview]
Message-ID: <20130205092003.GA5865@x2.net.home> (raw)
In-Reply-To: <20130204182338.GA15222@rhmail.home.annexia.org>
On Mon, Feb 04, 2013 at 06:23:38PM +0000, Richard W.M. Jones wrote:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=907554
All mkfs.<type> should be robust enough to wipe the device. I'm
currently working with guys around filesystems to improve mkfs.ext4
and mkfs.xfs
https://bugzilla.redhat.com/show_bug.cgi?id=902512
.. but nothing is perfect so explicitly call wipefs(8) from
installers or things like libguestfs is definitely good idea.
> We could change libguestfs's guestfs_mkfs (internally) so it always
> does an implicit wipefs on the filesystem. wipefs is not too onerous --
> in particular I believe it only writes to a few chosen areas of the
> disk. Especially considering that we're about to run mkfs anyway
> which for some filesystems writes a lot of blocks.
wipefs(8) (or blkid_do_wipe() from the library) wipes only magic
strings to make the filesystem (raids or partition tables) invisible
for libblkid. It means very few bytes.
> Thoughts?
Go ahead :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-02-05 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 18:23 [Libguestfs] Should we always do wipefs before mkfs? Discuss Richard W.M. Jones
2013-02-05 9:20 ` Karel Zak [this message]
2013-02-05 9:37 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205092003.GA5865@x2.net.home \
--to=kzak@redhat.com \
--cc=berrange@redhat.com \
--cc=libguestfs@redhat.com \
--cc=rjones@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox