From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: kerolasa@gmail.com, "Sami Kerola" <kerolasa@iki.fi>,
"Mantas Mikulėnas" <grawity@gmail.com>,
util-linux@vger.kernel.org
Subject: Re: lslocks – "failed to parse pid: 'WRITE'"
Date: Thu, 14 Feb 2013 16:02:00 +0100 [thread overview]
Message-ID: <20130214150200.GG19379@x2.net.home> (raw)
In-Reply-To: <20130212131830.GA18597@x2.net.home>
On Tue, Feb 12, 2013 at 02:18:30PM +0100, Karel Zak wrote:
> On Tue, Feb 12, 2013 at 12:56:10PM +0100, Bernhard Voelker wrote:
> > On 02/12/2013 12:23 PM, Sami Kerola wrote:
> > > Almost off topic.
> >
> > while we're at it - ;-)
> > is it necessary to open/read/close "/proc/self/mountinfo" so often?
> >
> > $ strace -e open ./lslocks 2>&1 | grep mountinfo | wc -l
> > 67
>
> especially when we have libmount in the same source tree :-) Just use
> mnt_new_table_from_file(_PATH_PROC_MOUNTINFO) and keep the pointer...
Fixed.
$ strace -e open ./lslocks 2>&1 | grep mountinfo | wc -l
1
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-02-14 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 14:42 lslocks – "failed to parse pid: 'WRITE'" Mantas M.
2013-02-11 22:42 ` Sami Kerola
2013-02-11 23:23 ` Mantas Mikulėnas
2013-02-12 11:12 ` Karel Zak
2013-02-12 11:23 ` Sami Kerola
2013-02-12 11:56 ` Bernhard Voelker
2013-02-12 13:18 ` Karel Zak
2013-02-14 15:02 ` Karel Zak [this message]
2013-02-12 13:20 ` Karel Zak
2013-02-14 15:44 ` Karel Zak
2013-02-12 10:35 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214150200.GG19379@x2.net.home \
--to=kzak@redhat.com \
--cc=grawity@gmail.com \
--cc=kerolasa@gmail.com \
--cc=kerolasa@iki.fi \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox