From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/7] kill: modernization after undeprecation
Date: Tue, 12 Mar 2013 15:29:58 +0100 [thread overview]
Message-ID: <20130312142958.GA26680@x2.net.home> (raw)
In-Reply-To: <1362698844-21292-1-git-send-email-kerolasa@iki.fi>
On Thu, Mar 07, 2013 at 11:27:17PM +0000, Sami Kerola wrote:
> Sami Kerola (7):
> kill: add long options
> kill: align with howto-usage-function.txt
> kill: use libc error printing facilities and exit values
> kill, procs: fix coding style
> kill, procs: move function declarations to kill.h
Not applied this one. The include/ headers are usually for lib/
stuff. The another reason that the misc-util/proc.c code would be
better to move to lib/procutils.c (after some refactoring) -- I'll
do that.
> kill, procs: use pid_t for pids
> docs: add long options and tidy up kill.1
>
> misc-utils/kill.1 | 88 ++++++-----
> misc-utils/kill.c | 442 ++++++++++++++++++++++++++---------------------------
> misc-utils/kill.h | 8 +-
> misc-utils/procs.c | 170 +++++++++++----------
> 4 files changed, 360 insertions(+), 348 deletions(-)
Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-03-12 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 23:27 [PATCH 0/7] kill: modernization after undeprecation Sami Kerola
2013-03-07 23:27 ` [PATCH 1/7] kill: add long options Sami Kerola
2013-03-07 23:27 ` [PATCH 2/7] kill: align with howto-usage-function.txt Sami Kerola
2013-03-07 23:27 ` [PATCH 3/7] kill: use libc error printing facilities and exit values Sami Kerola
2013-03-07 23:27 ` [PATCH 4/7] kill, procs: fix coding style Sami Kerola
2013-03-07 23:27 ` [PATCH 5/7] kill, procs: move function declarations to kill.h Sami Kerola
2013-03-07 23:27 ` [PATCH 6/7] kill, procs: use pid_t for pids Sami Kerola
2013-03-07 23:27 ` [PATCH 7/7] docs: add long options and tidy up kill.1 Sami Kerola
2013-03-12 14:29 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312142958.GA26680@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox