public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] loopdev: sync capacity after setting it
Date: Mon, 18 Mar 2013 14:18:27 +0100	[thread overview]
Message-ID: <20130318131827.GE2172@x2.net.home> (raw)
In-Reply-To: <51471122.6030804@suse.com>

On Mon, Mar 18, 2013 at 09:05:38AM -0400, Jeff Mahoney wrote:
> Yeah, but that's in losetup --set-capacity where it's an explicit
> operation. This change will add the ioctl into every
> loopdev_setup_device call when the offset or sizelimit options are used.
> If it isn't supported by the kernel, the ioctl will fail silently and
> *maybe* the mount will fail, but that's totally dependent on the the
> file system. If the mount succeeds, it will be done outside of the
> parameters the user requested.
> 
> So, all I really want to do is dump an error message when the ioctl
> fails with -ENOTTY || -EINVAL about there being a lack of kernel
> support. We shouldn't allow the device configuration to proceed.
> 
> The part that makes it more "fun" is that a few patches in 3.9-rc1 fixed
> this in the kernel, so it won't actually be needed for new kernels.

 Nasty... well, send patch.
 
    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2013-03-18 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 21:04 [PATCH] loopdev: sync capacity after setting it Jeff Mahoney
2013-03-17 14:18 ` Jeff Mahoney
2013-03-18  9:27   ` Karel Zak
2013-03-18 13:05     ` Jeff Mahoney
2013-03-18 13:18       ` Karel Zak [this message]
2013-03-27 20:45         ` [PATCH v2] " Jeff Mahoney
2013-04-09 12:39           ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130318131827.GE2172@x2.net.home \
    --to=kzak@redhat.com \
    --cc=jeffm@suse.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox