From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 6/7] whereis: canonicalize files before printing
Date: Wed, 20 Mar 2013 13:56:16 +0100 [thread overview]
Message-ID: <20130320125616.GA14833@x2.net.home> (raw)
In-Reply-To: <1363477219-29245-7-git-send-email-kerolasa@iki.fi>
On Sat, Mar 16, 2013 at 11:40:18PM +0000, Sami Kerola wrote:
> The whereis gives promise to find files so it seems to be more correct
> print symlink destinations than locations of symlinks.
Not sure. I think it's correct to canonicalize directory paths (to
avoid problems like /bin -> /usr/bin symlinks), but I don't see
a reason to canonicalize whole paths (filenames).
For example
$ whereis -b bzcat
bzcat: /usr/bin/bzcat
is expected answer, but
$ whereis -b bzcat
bzcat: /usr/bin/bzip2
looks strange. The another story is that many things are redirected
by symlinks to /etc/alternatives and then to pretty specific places.
Maybe we can add an option to canonicalize, but from my point of view
it should not be enabled by default.
I have applied patch to canonicalize directory names.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-03-20 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 23:40 [PATCH 0/7] pull: whereis changes Sami Kerola
2013-03-16 23:40 ` [PATCH 1/7] whereis: rewrite most of the command Sami Kerola
2013-03-16 23:40 ` [PATCH 2/7] whereis: add search scope listing option Sami Kerola
2013-03-16 23:40 ` [PATCH 3/7] whereis: align with howto-usage-function.txt Sami Kerola
2013-03-16 23:40 ` [PATCH 4/7] whereis: support MANPATH environment variable Sami Kerola
2013-03-16 23:40 ` [PATCH 5/7] docs: generic whereis.1 clean up Sami Kerola
2013-03-16 23:40 ` [PATCH 6/7] whereis: canonicalize files before printing Sami Kerola
2013-03-20 12:56 ` Karel Zak [this message]
2013-03-20 14:03 ` Sami Kerola
2013-03-16 23:40 ` [PATCH 7/7] whereis: remove duplicates from search results Sami Kerola
2013-03-20 12:59 ` Karel Zak
2013-03-17 9:23 ` [PATCH 0/7] pull: whereis changes Sami Kerola
2013-03-20 13:02 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320125616.GA14833@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox