Re: [PATCH] Add option to fsfreeze to call syncfs() prior to freezing.

Karel Zak
2013-03-20T13:28:16Z

On Sat, Dec 08, 2012 at 07:46:41PM +0000, Alun wrote:
> On Sat, 8 Dec 2012 07:47:43 -0500
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > On Fri, Dec 07, 2012 at 12:50:32PM +0000, Alun wrote:
> > > Christoph Hellwig <hch@infradead.org> said, in message
> > > 20121207124415.GA28504@infradead.org:
> > > >
> > > > It might be better to send a kernel patch to do a first async sync
> > > > attempt instead of band aiding this in one of the consumers.
> > >
> > > That's what I did originally - see
> > > http://marc.info/?t=135474654500003&r=1&w=2
> >
> > So let's keep the discussion there, if you do exactly the same call
> > from userspace the same arguments still apply.
>
> I'm out of my depth when it comes to the politics of all this. So I
> think I'm going to bow out now. I'd already got the solution to my
> specific issue (write a tiny "syncfs" program and call it from my
> script prior to taking a snapshot). While I'd like to try and help
> others avoid the same pitfall as me, I'm not motivated enough to
> blunder any further into this disagreement.

What is the current status of this issue?

Do we really need a special option (fsfreeze -s) to call syncfs()?
Cannot we call it always in fsfreeze(8)?

And if the thing will be implemented without the command line option
then we can later remove the syncfs() call when kernel will be improved.

Karel

--
Karel Zak <kzak@redhat.com>