From: Karel Zak <kzak@redhat.com>
To: Linda Walsh <lkml@tlinx.org>
Cc: util-linux@vger.kernel.org
Subject: Re: RFD: patch: su: ignoring switches and continuing: --preserve-environment v. --login
Date: Thu, 30 May 2013 09:33:30 +0200 [thread overview]
Message-ID: <20130530073330.GG30341@x2.net.home> (raw)
In-Reply-To: <51A66104.3060508@tlinx.org>
On Wed, May 29, 2013 at 01:11:48PM -0700, Linda Walsh wrote:
> > @@ -98,6 +98,7 @@ Preserves the whole environment, ie does not set
> > .B USER
> > nor
> > .BR LOGNAME .
> > +The option is ignored if the option \fB\-\-login\fR is specified.
> ---
> There are 2 problems
> On the surface, this patch, alone, appears to remove desirable
> functionality from su, and, it is a dangerous change in default
Did you read the code?
if (simulate_login) {
...
} else {
if (change_environment) {
....
}
}
the patch does not change anything...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-05-30 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 20:11 RFD: patch: su: ignoring switches and continuing: --preserve-environment v. --login Linda Walsh
2013-05-30 7:33 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530073330.GG30341@x2.net.home \
--to=kzak@redhat.com \
--cc=lkml@tlinx.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox