From: Karel Zak <kzak@redhat.com>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: Util-Linux <util-linux@vger.kernel.org>
Subject: Re: [patches] small textual fixes and comment tweaks
Date: Fri, 7 Jun 2013 11:49:26 +0200 [thread overview]
Message-ID: <20130607094926.GA24313@x2.net.home> (raw)
In-Reply-To: <1369851833.16416.140661237259173.1F6E43AA@webmail.messagingengine.com>
On Wed, May 29, 2013 at 08:23:53PM +0200, Benno Schulenberg wrote:
> The first patch standardizes the usage message of 'login' to the use of
It would be nice to have a real usage() function in login.c.
> angular brackets, the second standardizes the spelling of "super-user"
> to the more common "superuser", the third makes a minor tweak, and
> in the fourth patch I got carried away and reviewed all the comments
> in login.c -- if this is too much, I can redo the patch to contain just the
> grammar and typo fixes ("accout", "reinilizalize", ...).
It's OK to fix stupid typos and grammar mistakes in comments, but it's
probably overkill to clean up all comments in all utils.
It's usually better to do such massive changes together with code cleanup
(or after code cleanup). We recently did code refactoring in login,
eject, mount, umount, sulogin, cal, whereis, dmesg, etc.
The new code is also in lsblk, findmnt, lscpu, lslocks, prlimit, ...
But for now don't waste time with things like fdisk, hexdump, hwclock, etc.
Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-06-07 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 18:23 [patches] small textual fixes and comment tweaks Benno Schulenberg
2013-06-07 9:49 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607094926.GA24313@x2.net.home \
--to=kzak@redhat.com \
--cc=bensberg@justemail.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox