From: Karel Zak <kzak@redhat.com>
To: Gabriel de Perthuis <g2p.code@gmail.com>
Cc: Rolf Fokkens <rolf@rolffokkens.nl>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
util-linux <util-linux@vger.kernel.org>
Subject: Re: bcache-tools package for Fedora / status probe-bcache
Date: Wed, 11 Sep 2013 17:51:55 +0200 [thread overview]
Message-ID: <20130911155155.GA1053@x2.net.home> (raw)
In-Reply-To: <522DE939.5090009@gmail.com>
On Mon, Sep 09, 2013 at 05:28:57PM +0200, Gabriel de Perthuis wrote:
> It's correct insofar as current consumers expect it, and it's better
> for error reporting. The patches took care of my other objections,
> so you can keep the crc check and go with what's on
> https://github.com/g2p/util-linux/commits
> (the csum patches I sent + Rolf's patch + a patch that depends on both).
Merged with some changes
- not added blkid_probe_is_badcsum() the info about bad csum is
exported by SBBADCSUM=1 variable, you have to use for example:
if (blkid_probe_has_value(pr, "SBBADCSUM"))....
- the usage type is BLKID_USAGE_OTHER rather than "raid" (we have some
special exceptions and tests for raids that are unnecessary for
bcache)
I have also added the test images from Rolf to util-linux test suite.
$ blkid -o udev -p tests/output/blkid/images-fs/bcache-C.img
ID_FS_UUID=7a343627-ac87-4bf0-b76f-46067cbc9b8c
ID_FS_UUID_ENC=7a343627-ac87-4bf0-b76f-46067cbc9b8c
ID_FS_TYPE=bcache
ID_FS_USAGE=other
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-09-11 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <521A55D4.20908@rolffokkens.nl>
[not found] ` <52282A87.4000801@rolffokkens.nl>
[not found] ` <52285A03.7080802@gmail.com>
[not found] ` <FEBD3400-93F1-4286-8BE8-45D5413C2EA2@rolffokkens.nl>
2013-09-05 10:53 ` bcache-tools package for Fedora / status probe-bcache Gabriel de Perthuis
2013-09-09 13:26 ` Karel Zak
2013-09-09 15:28 ` Gabriel de Perthuis
2013-09-11 11:59 ` Rolf Fokkens
2013-09-11 15:51 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911155155.GA1053@x2.net.home \
--to=kzak@redhat.com \
--cc=g2p.code@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=rolf@rolffokkens.nl \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox