From: Karel Zak <kzak@redhat.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 3/3] libfdisk: gpt: loosen check fot pmbr size in lba
Date: Wed, 25 Sep 2013 11:27:11 +0200 [thread overview]
Message-ID: <20130925092711.GA30761@x2.net.home> (raw)
In-Reply-To: <1379821516-2540-3-git-send-email-davidlohr@hp.com>
On Sat, Sep 21, 2013 at 08:45:16PM -0700, Davidlohr Bueso wrote:
> While most disk partitioning tools out there create a pMBR's size in lba
> to be the lesser of the whole disk or 2Tib, Microsoft apparently does not[1].
> It always sets the entry to the maximum 32-bit limitation - even though a
> drive may be smaller than that.
>
> Loosen this check and only verify that the size is either the whole disk
> or 0xFFFFFFFF. No tool in its right mind would set it to any value
> other than these.
>
> [1] http://thestarman.pcministry.com/asm/mbr/GPT.htm#GPTPT
>
> Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
> ---
> libfdisk/src/gpt.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-09-25 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 3:45 [PATCH 1/3] libfdisk: gpt: avoid unnecessary pmbr check Davidlohr Bueso
2013-09-22 3:45 ` [PATCH 2/3] libfdisk: gpt: do not assume first pt record is always pmbr Davidlohr Bueso
2013-09-25 9:26 ` Karel Zak
2013-09-22 3:45 ` [PATCH 3/3] libfdisk: gpt: loosen check fot pmbr size in lba Davidlohr Bueso
2013-09-25 9:27 ` Karel Zak [this message]
2013-09-25 9:25 ` [PATCH 1/3] libfdisk: gpt: avoid unnecessary pmbr check Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925092711.GA30761@x2.net.home \
--to=kzak@redhat.com \
--cc=davidlohr@hp.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox