From: Karel Zak <kzak@redhat.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 3/4] libmount: Set each optstr's to NULL if failed
Date: Thu, 26 Sep 2013 09:53:07 +0200 [thread overview]
Message-ID: <20130926075307.GD5101@x2.net.home> (raw)
In-Reply-To: <1380123126-3030-3-git-send-email-namhyung@gmail.com>
On Thu, Sep 26, 2013 at 12:32:05AM +0900, Namhyung Kim wrote:
> When mnt_split_optstr() failed in the middle, vfs, fs, user optstr's
> are freed but not reset. It can lead to double frees at the end of
> mnt_fs_{ap,pre}pend_options().
It's bug that mnt_fs_{ap,pre}pend_options() functions use the
pointers after failed mnt_split_optstr().
Anyway, it's probably better to be robust here so applied and also
fixed mnt_fs_{ap,pre}pend_options().
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2013-09-26 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 15:32 [PATCH 1/4] libmount: Get rid of an unnecessary check Namhyung Kim
2013-09-25 15:32 ` [PATCH 2/4] libmount: Free splitted optstr's when error occurred Namhyung Kim
2013-09-26 7:50 ` Karel Zak
2013-09-25 15:32 ` [PATCH 3/4] libmount: Set each optstr's to NULL if failed Namhyung Kim
2013-09-26 7:53 ` Karel Zak [this message]
2013-09-25 15:32 ` [PATCH 4/4] libmount: Remove stale comment on mnt_context_mount() Namhyung Kim
2013-09-26 7:53 ` Karel Zak
2013-09-26 7:49 ` [PATCH 1/4] libmount: Get rid of an unnecessary check Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926075307.GD5101@x2.net.home \
--to=kzak@redhat.com \
--cc=namhyung@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox