From: Karel Zak <kzak@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] clean up term lib handling
Date: Fri, 4 Oct 2013 13:35:59 +0200 [thread overview]
Message-ID: <20131004113559.GE14360@x2.net.home> (raw)
In-Reply-To: <20130930130718.GN5101@x2.net.home>
On Mon, Sep 30, 2013 at 03:07:18PM +0200, Karel Zak wrote:
>
> I have applied the patch, but now when play with it I see that
>
> On Sun, Sep 29, 2013 at 12:44:43AM -0400, Mike Frysinger wrote:
> > With a minor tweak to how tinfo is handled, we can do the same thing -- we
> > just always use TINFO_LIBS in the Makefile's.
>
> you have introduced unnecessary dependence on ncurses for utils where
> was "ifdef tinfo *else* ncurses"
...
> Maybe we need to revert back to
>
> AM_CONDITIONAL([HAVE_TINFO], [test "x$have_tinfo" = xyes])
Done. It also seems that we can use pkg-config for tinfo.
Please, test the changes in your environment. Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-10-04 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 4:44 [PATCH] clean up term lib handling Mike Frysinger
2013-09-30 13:07 ` Karel Zak
2013-10-04 11:35 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004113559.GE14360@x2.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox