From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [0000/0010] cal: code revisit part I
Date: Thu, 31 Oct 2013 13:14:56 +0100 [thread overview]
Message-ID: <20131031121456.GF1536@x2.net.home> (raw)
In-Reply-To: <1382906556-16442-1-git-send-email-kerolasa@iki.fi>
On Sun, Oct 27, 2013 at 08:42:26PM +0000, Sami Kerola wrote:
> I got the --one and --three outputs working, but I am not completely
> happy about the --three. Quite frankly better function would take input
> how many horizontal calendar outputs are needed, and would do exactly
> that. Such function would be more reusable when considering yearly
> output, and the fact it has two column output when in julian mode.
Yes, in the final output function should not be hardcoded a number of
months -- it would be better to have a generic function that
is able to use arbitrary list/array of the months. The list/array of
the months should be composed in another function.
Now it's possible to print only 1, 3 or 12 months, and all is
hardcoded. It would be nice to have a way how to print arbitrary
number of months (or arbitrary range).
For example it would be nice to have a way how to specify a quarter
of the company fiscal year (!= calendar year). I can imagine
something like --month=<list> option or so..
> Karel, it is be best not to merge the last patch. It is more of
> work-in-progress, comments would be great.
I'll probably wait for whole code refactoring rather than merge
an incomplete thing.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2013-10-31 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 20:42 [0000/0010] cal: code revisit part I Sami Kerola
2013-10-27 20:42 ` [PATCH 01/10] cal: use control structure for run time configuration Sami Kerola
2013-10-31 11:29 ` Karel Zak
2013-10-27 20:42 ` [PATCH 02/10] cal: add input variable names to function prototypes Sami Kerola
2013-10-27 20:42 ` [PATCH 03/10] cal: make day_in_week() use same variable names as other functions Sami Kerola
2013-10-27 20:42 ` [PATCH 04/10] cal: simplify ascii_wnum() function Sami Kerola
2013-10-27 20:42 ` [PATCH 05/10] cal: determine output width at beginning of run and reuse result Sami Kerola
2013-10-31 11:34 ` Karel Zak
2013-10-27 20:42 ` [PATCH 06/10] tests: cal: take account week numbers when determing month lenght Sami Kerola
2013-10-27 20:42 ` [PATCH 07/10] cal: make user request to be part of read-only control struct Sami Kerola
2013-10-31 11:49 ` Karel Zak
2013-11-01 9:29 ` Sami Kerola
2013-10-27 20:42 ` [PATCH 08/10] cal: determine how many header lines are needed at initialization Sami Kerola
2013-10-27 20:42 ` [PATCH 09/10] cal: add month contents structure Sami Kerola
2013-10-27 20:42 ` [PATCH 10/10] cal: make cal --three to use content structures Sami Kerola
2013-10-31 12:14 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031121456.GF1536@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox