Re: RFQ: changes on ldattach.c for GSM710 discipline

[Karel Zak <kzak@redhat.com>]

On Fri, Nov 15, 2013 at 04:06:16PM +0100, Martin Schmid wrote:
> I'm just preparing for some add-ons and wanted to check if someone else is
> working on it and if my ideas are not too far away from what is the
> intention of the tool.
> 
> I'd like to add support for N_GSM710 that comes with the kernel module
> n_gsm. Someone else ('guowenxue') has already brought a slightly patched
> version into the wild which is too restricted and specific.
> 
> The planned features are:
> 
> - setting the GSM710 discipline
> - sending a configurable string out (parameter '--mux' or '-m', default
> AT+CMUX=0)
> - configurable pause in seconds after the command (parameter '--pause' or
> -p)
> - UUCP lock file support (-l or --lock, default none,
> '/var/lock/<devicename>' if no argument is given)

 Please, don't send one huge patch - split it per-feature.

 Do we really need support for the locks? There is lockdev(3)
 (although it seems currently unmaintained).

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com