public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: util-linux@vger.kernel.org
Subject: tests: cal/bigyear only works on 64bit (sizeof(long) == 8) systems
Date: Sun, 22 Dec 2013 21:42:43 -0500	[thread overview]
Message-ID: <201312222142.44536.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

the cal bigyear test uses a year of 1234567890123456789, but the parsing logic 
reads it in like so:
	year = strtol_or_err(*argv++, _("illegal year value"));

that's a signed long type, so on 32bit systems, you get:
          cal: Year 1234567890123456789       ...cal: illegal year value: 
'1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
cal: illegal year value: '1234567890123456789': Numerical result out of range
 FAILED (cal/bigyear)

should the test detect the sizeof(long) and then calculate a number that is 
smaller than that ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2013-12-23  2:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  2:42 Mike Frysinger [this message]
2014-01-06 12:30 ` tests: cal/bigyear only works on 64bit (sizeof(long) == 8) systems Karel Zak
2014-01-06 12:55   ` Sami Kerola
2014-01-06 13:08     ` Karel Zak
2014-01-06 23:21       ` Sami Kerola
2014-01-13 12:02         ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312222142.44536.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox