public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] tests: libmount: skip tabfiles-py when pylibmount is disabled
Date: Mon, 6 Jan 2014 12:52:26 +0100	[thread overview]
Message-ID: <20140106115226.GE14933@x2.net.home> (raw)
In-Reply-To: <1387756892-25074-1-git-send-email-vapier@gentoo.org>

On Sun, Dec 22, 2013 at 07:01:32PM -0500, Mike Frysinger wrote:
> The default configure disables python support, so this test fails by
> default.  Add a simple check for module availability.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  tests/ts/libmount/tabfiles-py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/ts/libmount/tabfiles-py b/tests/ts/libmount/tabfiles-py
> index 64e8911..b89fb5b 100755
> --- a/tests/ts/libmount/tabfiles-py
> +++ b/tests/ts/libmount/tabfiles-py
> @@ -12,6 +12,8 @@ ts_init_py libmount
>  PYDBG="$PYTHON -m pdb"
>  TESTPROG="$TS_HELPER_PYLIBMOUNT_TAB"
>  
> +$PYTHON -c 'import libmount' 2>/dev/null || ts_skip "pylibmount not compiled"
> +

Hmm... in function ts_init_py() is

    [ -f "$TS_TOPDIR/../py${LIBNAME}.la" ] || ts_skip "py${LIBNAME} not compiled"

and it works for me:

    $ ./ts/libmount/tabfiles-py te     libmount: tab files-py... IGNORE (pylibmount not compiled)

fixed by:

   commit f48145b500cc214746ae5dca997098ad22f41ead
   Author: Karel Zak <kzak@redhat.com>
   Date:   Thu Oct 3 16:20:38 2013 +0200

    testsL fix py<libname> check


    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply	other threads:[~2014-01-06 11:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  0:01 [PATCH] tests: libmount: skip tabfiles-py when pylibmount is disabled Mike Frysinger
2014-01-06 11:52 ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106115226.GE14933@x2.net.home \
    --to=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox