Re: [PATCH] uuidd: use pkg-config to find systemd-deamon support

Sami Kerola
2014-01-10T14:29:28Z

On 9 January 2014 16:56, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 08 January 2014 17:28:06 Sami Kerola wrote:
>> include tests/Makemodule.am
>> +endif # HAVE_COMMANDS
>
> aren't there some tests for the libs ?

There are some. Taking in consideration Karel's proposal to have
--disable-all-builds that could be combined with
--enable-<per-subdirectory> the tests cannot be skipped in build root
Makefile.am level.

>> +AM_CONDITIONAL(HAVE_COMMANDS, test "x$enable_libraries_only" = xyes)
>
> i'm not sure about this inversion of naming. why can't it just use
> enable_binaries everywhere ?

Yes, I agree the names could have been better but I did not bother
making the very first hastily wrote patch 100% correct, which is good
since --enable-libraries-only or --disable-commands does not seem to
be what is needed.

>> --- a/login-utils/Makemodule.am
>> +++ b/login-utils/Makemodule.am
>> -install-exec-hook:
>> -if BUILD_SU
>> -if MAKEINSTALL_DO_SETUID
>> - chmod 4755 $(DESTDIR)$(bindir)/su
>> -endif
>> -endif
>> -if BUILD_VIPW
>> - cd $(DESTDIR)$(usrsbin_execdir) && ln -sf vipw vigr
>> -endif
>
> why does this need to move ? this module isn't included when commands are
> disabled ...

automake gave warning the install-exec-hook was if'd out. I think the
sudo suid & vipw will need to use INSTALL_EXEC_HOOKS, and this is
patch has to precede --disable-all-builds change.

--
Sami Kerola