From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:1202 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbaAOJzd (ORCPT ); Wed, 15 Jan 2014 04:55:33 -0500 Date: Wed, 15 Jan 2014 10:55:28 +0100 From: Karel Zak To: Phillip Susi Cc: Scott Moser , util-linux@vger.kernel.org Subject: Re: [PATCH] fix partx --update ranges and out of order tables Message-ID: <20140115095528.GJ12700@x2.net.home> References: <20140114085439.GF12700@x2.net.home> <52D54D09.10506@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <52D54D09.10506@ubuntu.com> Sender: util-linux-owner@vger.kernel.org List-ID: On Tue, Jan 14, 2014 at 09:43:21AM -0500, Phillip Susi wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > +blkid_partition get_partition_by_partno(blkid_partlist ls, int n) > > I was wondering why libblkid didn't already have a function like this, > should this be moved there instead of just being in partx.c? Yes, good point. I have moved the function to libblkid in the master branch (in the stable/v2.24 is the original Scott's version -- I don't want to change the API in x.y.1 releases). Thanks. Karel -- Karel Zak http://karelzak.blogspot.com