public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Michael Marineau <michael.marineau@coreos.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] libblkid: add PARTTYPE tag
Date: Mon, 10 Feb 2014 10:57:09 +0100	[thread overview]
Message-ID: <20140210095709.GC8506@x2.net.home> (raw)
In-Reply-To: <1389734390-32485-1-git-send-email-michael.marineau@coreos.com>

On Tue, Jan 14, 2014 at 01:19:49PM -0800, Michael Marineau wrote:
> Add PARTTYPE to make searching for devices partition possible without
> dropping to the low-level probe API and searching all devices by
> PART_ENTRY_TYPE. For example to find any 'EFI System Partition' devices:
> 
> $ blkid -t PARTTYPE=c12a7328-f81f-11d2-ba4b-00a0c93ec93b
> ---
>  libblkid/src/verify.c | 2 ++
>  1 file changed, 2 insertions(+)

 I think it's unnecessary (and maybe bad idea) to add a new tags to
 the high level part of the library. The high level tags have been
 introduced to support mount/fsck devices by LABEL= or UUID= tags
 (only this is reason why we have the new PARTUUID= tag there). I'd
 like to keep this layer as minimal as possible (due the problem with
 caching in blkid.tab file).
 
 If you need information about devices then use lsblk(8) rather than
 blkid(8).

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  parent reply	other threads:[~2014-02-10  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 21:19 [PATCH 1/2] libblkid: add PARTTYPE tag Michael Marineau
2014-01-14 21:19 ` [PATCH 2/2] lsblk: " Michael Marineau
2014-02-10  9:49   ` Karel Zak
2014-02-10  9:57 ` Karel Zak [this message]
2014-02-10 21:54   ` [PATCH 1/2] libblkid: " Michael Marineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210095709.GC8506@x2.net.home \
    --to=kzak@redhat.com \
    --cc=michael.marineau@coreos.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox