From: Jesper Dahl Nyerup <nyerup@one.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] scriptreplay: Add --maxdelay option.
Date: Mon, 10 Feb 2014 20:10:01 +0100 [thread overview]
Message-ID: <20140210191000.GA19280@one.com> (raw)
In-Reply-To: <20140210182536.GS8506@x2.net.home>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Feb 10 19:25, Karel Zak wrote:
> On Mon, Feb 10, 2014 at 11:53:18AM +0100, Jesper Dahl Nyerup wrote:
> > term-utils/scriptreplay.1 | 6 ++++++
> > term-utils/scriptreplay.c | 15 ++++++++++++---
> > 2 files changed, 18 insertions(+), 3 deletions(-)
>
> Applied, thanks.
Back atcha.
> > + double divi = 1, maxdelay = 10;
>
> I have used maxdelay = 0; it seems more readable :-)
Fine by me.
I had 0 in my patch initially, but changed it to 10. The only reason was
if someone someday decided to make the option argument optional, a
default value of 0 would effectively render scriptreplay(1) to be a
poorly implemented cat(1).
But let's cross that bridge when we reach it.
J.
--
Jesper Dahl Nyerup
Systems Engineer
One.com, nyerup@one.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-02-10 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 10:53 [PATCH] scriptreplay: Add --maxdelay option Jesper Dahl Nyerup
2014-02-10 18:25 ` Karel Zak
2014-02-10 19:10 ` Jesper Dahl Nyerup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210191000.GA19280@one.com \
--to=nyerup@one.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox