From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: Util-Linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] libmount: define BTRFS_TEST_MAGIC if missing
Date: Wed, 5 Mar 2014 12:27:04 +0100 [thread overview]
Message-ID: <20140305112704.GE13353@x2.net.home> (raw)
In-Reply-To: <531702A6.2070903@bernhard-voelker.de>
On Wed, Mar 05, 2014 at 11:55:34AM +0100, Bernhard Voelker wrote:
> * libmount/src/utils.c (BTRFS_TEST_MAGIC): Conditionally add define
> which is used since commit v2.24-243-g6a52473.
Applied, thanks.
Unfortunately, this is not end of the statfs f_type horror -- all
depends on kernel headers version, stuff in linux/magic.h, etc. And
the list of the filesystems is also not complete.
So I guess we will see more reports...
Maybe the best would be to create our private include/statfs_magic.h
with ifndef-define for all filesystems.
I'm trying to cleanup this thing in kernel tree, but the result is
doubtful
http://www.spinics.net/lists/linux-fsdevel/threads.html#73297
and we still need compatibility with already released kernels.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-03-05 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:55 [PATCH] libmount: define BTRFS_TEST_MAGIC if missing Bernhard Voelker
2014-03-05 11:27 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305112704.GE13353@x2.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox