From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 01/10] findfs: use symbolic exit values, and tell about them in manual
Date: Wed, 12 Mar 2014 11:37:12 +0100 [thread overview]
Message-ID: <20140312103712.GK9303@x2.net.home> (raw)
In-Reply-To: <1394397023-7050-1-git-send-email-kerolasa@iki.fi>
On Sun, Mar 09, 2014 at 03:30:14PM -0500, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
> include/exitcodes.h | 5 +++++
> misc-utils/findfs.8 | 30 ++++++++++++++++++++++++++----
> misc-utils/findfs.c | 13 +++++++------
> 3 files changed, 38 insertions(+), 10 deletions(-)
>
> diff --git a/include/exitcodes.h b/include/exitcodes.h
> index 24ee123..fc893f1 100644
> --- a/include/exitcodes.h
> +++ b/include/exitcodes.h
> @@ -32,4 +32,9 @@
> #define MOUNT_EX_FAIL 32 /* mount failure */
> #define MOUNT_EX_SOMEOK 64 /* some mount succeeded */
>
> +/* Exit codes used by findfs. */
> +#define FINDFS_SUCCESS 0 /* no errors */
> +#define FINDFS_NOT_FOUND 1 /* label or uuid cannot be found */
> +#define FINDFS_USAGE_ERROR 2 /* user did something unexpected */
Do we really need to add findfs exit codes to exitcodes.h? The
codes are specific to findfs and no shared anywhere.
It would be also better to use FINDFS_EX_{SUCCESS,NOTFOUND,USAGE}.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-03-12 10:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 20:30 [PATCH 01/10] findfs: use symbolic exit values, and tell about them in manual Sami Kerola
2014-03-09 20:30 ` [PATCH 02/10] kill: fix coding style Sami Kerola
2014-04-07 9:36 ` Karel Zak
2014-04-07 14:09 ` Sami Kerola
2014-03-09 20:30 ` [PATCH 03/10] kill: flip all comparions to be in smaller - greater order Sami Kerola
2014-03-19 12:32 ` Benno Schulenberg
2014-03-19 19:35 ` Sami Kerola
2014-03-19 20:30 ` Benno Schulenberg
2014-03-09 20:30 ` [PATCH 04/10] kill: move magic numbers in beginning of the file Sami Kerola
2014-03-09 20:30 ` [PATCH 05/10] kill: make usage() not to return Sami Kerola
2014-03-19 12:37 ` Benno Schulenberg
2014-03-19 19:02 ` Sami Kerola
2014-03-09 20:30 ` [PATCH 06/10] kill: leeway deprecation of --pid invocation as command name Sami Kerola
2014-03-11 7:21 ` Bernhard Voelker
2014-03-11 12:13 ` Sami Kerola
2014-04-07 8:30 ` Karel Zak
2014-03-09 20:30 ` [PATCH 07/10] kill: use control structure to pass user input to functions Sami Kerola
2014-04-07 9:28 ` Karel Zak
2014-03-09 20:30 ` [PATCH 08/10] kill: tell what is wrong rather than output usage() Sami Kerola
2014-03-09 20:30 ` [PATCH 09/10] kill: add parse_arguments() function Sami Kerola
2014-03-09 20:30 ` [PATCH 10/10] kill: move sigqueue inputs to control struct Sami Kerola
2014-03-12 10:37 ` Karel Zak [this message]
2014-03-13 16:49 ` [PATCH 01/10] findfs: use symbolic exit values, and tell about them in manual Sami Kerola
2014-03-26 11:19 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312103712.GK9303@x2.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox